Introduce .build_ignore file #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuraj17
requested review from
fallwith,
hannahramadan,
kaylareopelle and
tannalynn
as code owners
|
|
github-actions
bot
added
the
community
|
Thanks for contributing! It looks like bundler ran into an issue parsing this change. This is the output: Once this is addressed, I'll take a look again and make sure everything is good! |
manuraj17
force-pushed
the
build-ignore-files
branch
from
18a0608 to
06642a1
Compare
|
@tannalynn My bad! I missed out a bracket, since there were no tests for this I just added the snippet and pushed for feedback. I have made changes and tried building the gem as well. |
Files to be ignored during build are added in a simple text file, newline seperated. We then iterate and reject.
manuraj17
force-pushed
the
build-ignore-files
branch
from
06642a1 to
eabb0eb
Compare
|
@tannalynn I had force pushed the changes to keep the commit history clean of minor changes - I forgot to confirm if that was a habit followed here. You might want to delete and pull this branch again to avoid conflicts. Sorry about that, will restrict to normal push. |
tannalynn
approved these changes
Jun 23, 2023
This was referenced Jun 23, 2023
kaylareopelle
added a commit
that referenced
this pull request
Jul 5, 2023
The test/agent_helper.rb file was overlooked in our switch to the new file inclusion process introduced in PR#2089 #2089 This file is required for the public API NewRelic::Agent.require_test_helper. Furthermore, build.rb was still included. This file used to be generated with Jenkins during our release process and has not been created with a release since version 6.13.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1150
The requirement was to reduce the number of files that were added to the release build.
Introducing a new simple text file
.build_ignorewhich containst the list of files to be rejected. In the gemspec file we update therejectmethod definition to reject files listed in this file. It involes nested loops at the moment so not the best of efficiency, although we are dealing with very less amount of data hence should not take up too much time. We can always look into optimisations. We can treat this as a starting point.Changes are only currently added to
newrelic_rpm.gemspecto get feedback.This is one of my first contribution here, so aplogies in advance if I have broken any contribution guidelines uknowingly. Please call it out so that I can correct them.